Makefile.am patchview-wrapper script: drop EXEEXT#172
Merged
Conversation
…EEXT
patchutils 0.4.5 adds a patchview-wrapper python script used by
{git{diff,show},svndiff}view to run patchview alias symlink to
filterdiff exe or directly.
Makefile.am suffixes this script only with $(EXEEXT) but does not suffix
the other scripts provided, causing not found errors as the script is
not compiled to an executable suffixed with $(EXEEXT).
Treat patchview-wrapper like other shell and perl scripts by not
appending $(EXEEXT).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 0.4.x #172 +/- ##
=======================================
Coverage 83.60% 83.60%
=======================================
Files 5 5
Lines 4215 4215
Branches 1006 1006
=======================================
Hits 3524 3524
Misses 691 691
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Sorry I think that it was my mistake , I tested this patch in Linux and builds fine |
Owner
Author
|
Don't worry, I didn't catch it either. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patchview-wrapper script was incorrectly suffixed with $(EXEEXT) causing "not found" errors since it's not a compiled executable.
Fixes #171