-
Notifications
You must be signed in to change notification settings - Fork 9
Enable KSM for KubeVirt #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable KSM for KubeVirt #192
Conversation
The Kernel Samepage Merging should help in reducing the memory footprint for the test. See: https://kubevirt.io/user-guide/cluster_admin/ksm/ Signed-off-by: Alice Frosi <afrosi@redhat.com>
|
When the CI is more stable, we could try to run some of the tests in parallel and the KSM can help in reducing the memory consumption |
|
/cc @yalzhang |
Jakob-Naucke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to merging this in any case, but have you compared actual memory usage by any chance? If it allows to parallelize tests that OOMed previously it would be very useful
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alicefr, Jakob-Naucke The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@alicefr: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No I haven't, but it merges and shares several pages. So, it should help decreasing the memory footprint. I can try to come up with the memory saving on the next run of the tests |
|
With the page sharing and letting running 4 VMs in parallel with 4GB memory for 2 min, we save around 2172 MB. I calculated with this command |
4d69a38
into
trusted-execution-clusters:main
The Kernel Samepage Merging should help in reducing the memory footprint for the tests. See:
https://kubevirt.io/user-guide/cluster_admin/ksm/