Update Container images to fedora 43#172
Update Container images to fedora 43#172Jakob-Naucke merged 2 commits intotrusted-execution-clusters:mainfrom
Conversation
|
Hi @yairpod. Thanks for your PR. I'm waiting for a trusted-execution-clusters member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The PR looks good to me. But I more wondering if we should tag the buildroot with the fedora version instead of latest. It isn't clear on which fedora is built from and when 44 becomes the new latest, then we might accidentally switch to 44. |
Jakob-Naucke
left a comment
There was a problem hiding this comment.
LGTM, but as per the lint result, you'll also need to update the toolchain in .github. See also #116.
But I more wondering if we should tag the buildroot with the fedora version instead of latest.
@alicefr yes, :fedora is whatever buildroot updates to, and incidentally, we've been building on an F43 (not F42) buildroot that's slowly been running out of date. We could move buildroot to tagging the version too (and then, ideally, having dependabot update to latest not rawhide)
742c0a1 to
cd85fac
Compare
1424dbc to
4513e66
Compare
Yes, we should tag with the version, using latest can lead to picking up too new environment and creates confusion |
4513e66 to
4131b91
Compare
Updating all Fedroa container images to version 43. Also updating rust version to 1.88 Signed-off-by: Yair Podemsky <ypodemsk@redhat.com>
4131b91 to
bde2d8d
Compare
bde2d8d to
9a676bc
Compare
Minimum rust version was set to 1.85. Fedora is way above that threshold at the moment. Future EL releases will be above that as well. While on it, fix some of the linter errors that arise from the minimum version update. Co-authored-by: Yair Podemsky <ypodemsk@redhat.com> Signed-off-by: Beñat Gartzia Arruabarrena <bgartzia@redhat.com>
9a676bc to
5687211
Compare
|
@yairpod: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alicefr, Jakob-Naucke, yairpod The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
be1436b
into
trusted-execution-clusters:main
Updating all Fedroa container images to version 43. Also updating rust version to 1.92