OpenAI Admin Key Detector #4689
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustansir14
reviewed
Jan 23, 2026
mustansir14
reviewed
Jan 23, 2026
mustansir14
requested changes
Jan 23, 2026
added tests to check exclusivity tightened regexes
mustansir14
reviewed
Jan 28, 2026
shahzadhaider1
approved these changes
Jan 28, 2026
Contributor
Author
|
I ran additional tests against the corpora datasets. The detector did not appear in any of the outputs, so this looks safe to merge 
|
nabeelalam
reviewed
Feb 3, 2026
| // Matches: legacy keys (sk-{alnum}T3BlbkFJ...), project keys (sk-proj-...), | ||
| // service account keys (sk-svcacct-... or sk-service-...) | ||
| // Does NOT match: admin keys (sk-admin-...) | ||
| keyPat = regexp.MustCompile(`\b(sk-(?:(?:proj|svcacct|service)-[[:alnum:]_-]+|[a-zA-Z0-9]+)T3BlbkFJ[[:alnum:]_-]+)\b`) |
Contributor
There was a problem hiding this comment.
nit: [:alnum:] and [a-zA-Z0-9] are interchangeable so using either one throughout the regex would be more consistent
nabeelalam
reviewed
Feb 3, 2026
|
|
||
| // Keywords are used for efficiently pre-filtering chunks. | ||
| func (s Scanner) Keywords() []string { | ||
| return []string{"sk-admin-"} |
Contributor
There was a problem hiding this comment.
Similarly in openai.go, the keyword could be updated to sk-proj, sk-svcacct, and sk-service.
nabeelalam
approved these changes
Feb 3, 2026
Contributor
nabeelalam
left a comment
nabeelalam
left a comment
There was a problem hiding this comment.
Looks good. Just a couple non-blocking comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds OpenAI Admin Key Detector and enhances the pre-existing OpenAI detector to skip Admin Key verification
Checklist:
make test-community)?make lintthis requires golangci-lint)?