-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[INS-254] Datadog detector verification fix and endpoint configuration #4616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MuneebUllahKhan222
wants to merge
19
commits into
trufflesecurity:main
Choose a base branch
from
MuneebUllahKhan222:datadog-detector-verification-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[INS-254] Datadog detector verification fix and endpoint configuration #4616
MuneebUllahKhan222
wants to merge
19
commits into
trufflesecurity:main
from
MuneebUllahKhan222:datadog-detector-verification-fix
+133
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashifkhan0771
requested changes
Dec 24, 2025
2 tasks
kashifkhan0771
requested changes
Dec 26, 2025
kashifkhan0771
approved these changes
Dec 29, 2025
Contributor
|
Good work 🚀 |
shahzadhaider1
approved these changes
Dec 30, 2025
nabeelalam
approved these changes
Dec 30, 2025
Contributor
nabeelalam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
2 tasks
Open
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Datadog token verification previously relied on an App-key–dependent endpoint (/api/v2/users) to validate the Application Key + API Key combination. If this endpoint returned an error (for example, due to insufficient App Key permissions), the detector would mark the token as unverified and skip API key validation entirely.
Additionally, Datadog uses region-specific API endpoints. When the hard-coded cloud endpoint did not match the user’s actual region, verification requests were sent to the wrong endpoint.
This behaviour caused valid Datadog API keys to be reported as unverified, resulting in false negatives.
To resolve this issue I have done the following changes:
Removed API key validation from this detector and introduced a dedicated API key detector here
Added support for user-provided Datadog endpoints.
Checklist:
make test-community)?make lintthis requires golangci-lint)?