fix: remove unused GzEncoder import in decompression#647
Merged
jplatte merged 1 commit intotower-rs:mainfrom Feb 17, 2026
Merged
fix: remove unused GzEncoder import in decompression#647jplatte merged 1 commit intotower-rs:mainfrom
jplatte merged 1 commit intotower-rs:mainfrom
Conversation
jplatte
force-pushed
the
fix/remove-GzEncoder-import
branch
from
63f60dc to
42e5e4e
Compare
jplatte
approved these changes
Feb 17, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Hi! This is a very, very minor PR but, I noticed that
flate2::write::GzEncoderwas imported in the decompression module but doesn't seem to be used in the actual source code. I have tested removing it to see if anything would break.Solution
Removed the unused
use flate2::write::GzEncoder;import fromtower-http/src/decompression/mod.rs.Testing
I ran
cargo test --docto make sure the documentation examples still compile correctly (since they have their own imports), and all 75 tests passed! I also ran the regular test suite to verify nothing broke (except for a few unrelated deprecation warning in auth modules).Please let me know if I missed anything or if this change makes sense. Thank you!