Skip to content

fix(PM-4004, PM-4005): Fix tools page in account settings #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkartunov merged 3 commits into from
Feb 26, 2026
Merged

fix(PM-4004, PM-4005): Fix tools page in account settings #1493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
277aab6
PM-4004 #time 3h root cause and fixing modal not closed when cancel c…
hentrymartin Feb 25, 2026
e71dc1a
PM-4005 #time 3h fix edit tool items
hentrymartin Feb 25, 2026
bc416ae
removed console log
hentrymartin Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/apps/accounts/src/settings/tabs/tools/service-provider/ServiceProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,7 @@ const ServiceProvider: FC<ServiceProviderProps> = (props: ServiceProviderProps)
type='text'
error={formErrors.serviceProviderName}
dirty
forceUpdateValue
Copy link

@github-actions github-actions bot Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
The forceUpdateValue prop is being added to the InputText component. Ensure that this prop is supported by the component and behaves as expected. If this is a custom prop, verify its necessity and implementation to avoid unintended side effects.

/>
<div className={styles.formCTAs}>
{!isEditMode && <IconOutline.PlusCircleIcon />}
Expand Down
1 change: 1 addition & 0 deletions src/apps/accounts/src/settings/tabs/tools/software/Software.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@ const Software: FC<SoftwareProps> = (props: SoftwareProps) => {
name='softwareName'
label='Software Name *'
value={selectedSoftwareName}
forceUpdateValue
Copy link

@github-actions github-actions bot Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
The forceUpdateValue prop is not a standard prop for InputText. Ensure that this prop is supported by the component or remove it if unnecessary. Using unsupported props can lead to unexpected behavior.

onChange={handleSoftwareNameChange}
placeholder='Type here the Software Name'
tabIndex={0}
Expand Down
1 change: 1 addition & 0 deletions src/apps/accounts/src/settings/tabs/tools/subscriptions/Subscriptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ const Subscriptions: FC<SubscriptionsProps> = (props: SubscriptionsProps) => {
type='text'
error={formErrors.subscriptionName}
dirty
forceUpdateValue
Copy link

@github-actions github-actions bot Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
The forceUpdateValue prop is added to the InputText component. Ensure that this prop is necessary and correctly implemented in the InputText component. If it forces a re-render or bypasses controlled component behavior, it could lead to unexpected side effects.

/>
<div className={styles.formCTAs}>
{!isEditMode && <IconOutline.PlusCircleIcon />}
Expand Down
2 changes: 1 addition & 1 deletion src/libs/ui/lib/components/modals/confirm/ConfirmModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const ConfirmModal: FC<ConfirmModalProps> = (props: ConfirmModalProps) => {
props.onClose?.()
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [isLoading])
}, [isLoading, props.open])
Copy link

@github-actions github-actions bot Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ correctness]
Adding props.open to the dependency array of useCallback is correct to ensure the handleClose function updates when props.open changes. However, ensure that props.open is indeed a necessary dependency and that its inclusion does not cause unnecessary re-renders or logic issues.


return (
<BaseModal
Expand Down
Loading