Skip to content

PM-2394 cleanup looker based member verification #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
himaniraghav3 wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

PM-2394 cleanup looker based member verification #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
357145a
Merge pull request #5 from topcoder-platform/develop
Sep 30, 2021
b4224e0
Merge pull request #30 from topcoder-platform/develop
Oct 13, 2021
feb670d
Merge pull request #38 from topcoder-platform/develop
Oct 20, 2021
fe5eeb6
Merge pull request #60 from topcoder-platform/develop
Gunasekar-K May 18, 2023
aaee4f5
Merge pull request #62 from topcoder-platform/develop
eisbilir Oct 6, 2023
36b7855
Merge pull request #63 from topcoder-platform/develop
Gunasekar-K Jan 8, 2025
7128822
PM-2394 cleanup looker based member verification
himaniraghav3 Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions config/default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ module.exports = {
},

ID_VERIFICATION_PROCESSOR_CRON_EXPRESSION: process.env.ID_VERIFICATION_PROCESSOR_CRON_EXPRESSION || '0 */12 * * *',
PAUSE_ID_VERIFICATION: process.env.PAUSE_ID_VERIFICATION || false,
FETCH_LOOKER_VERIFIED_MEMBER_TIMEFRAME_DAYS: process.env.FETCH_LOOKER_VERIFIED_MEMBER_TIMEFRAME_DAYS || '3',
// looker-api config
lookerConfig: {
BASE_URL: process.env.LOOKER_API_BASE_URL || '', // looker api base url
Expand Down
12 changes: 0 additions & 12 deletions src/common/LookerApi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,6 @@ function LookApi (logger) {
this.lookAuth = new LookAuth(logger)
}

/**
* Find recent verified members
* @param {String} duration the verification date duration to filter
* @returns an array of verified members
*/
LookApi.prototype.findRecentVerifiedMembers = function (duration) {
Copy link

@kkartunov kkartunov Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove all occurances of findRecentVerifiedMembers from the code as well:
https://github.com/search?q=repo%3Atopcoder-platform%2Fonboarding-processor%20findRecentVerifiedMembers&type=code

const view = 'member_verification'
const fields = ['member_verification.user_id', 'member_verification.verification_mode', 'member_verification.status', 'member_verification.matched_on', 'member_verification.verification_date']
const filters = { 'member_verification.verification_date': duration }
return this.runQueryWithFilter('member_profile', view, fields, filters)
}

/**
* Run query with filter
* @param {String} model the model name
Expand Down
143 changes: 0 additions & 143 deletions src/services/IdVerificationProcessorService.js
View file
Open in desktop

This file was deleted.