calendar: provide deterministic editor context for item action clicks and editor item handling#65
Open
DeBaschdi wants to merge 3 commits intothunderbird:mainfrom
Open
calendar: provide deterministic editor context for item action clicks and editor item handling#65DeBaschdi wants to merge 3 commits intothunderbird:mainfrom
DeBaschdi wants to merge 3 commits intothunderbird:mainfrom
Conversation
Improves calendarItemAction toolbar persistence across restart and upgrade in calendar event editors (dialog + tab). Stop mutating xulStore in onShutdown(). Ensure button placement on ADDON_INSTALL and ADDON_UPGRADE. Cover both toolbars: event-toolbar and event-tab-toolbar.
… and editor item handling This proposal improves editor-context handling for calendar add-ons in dialog and tab editors: - include editorRef/editorType in calendarItemAction.onClicked info - support deterministic editor-targeted item access/update in calendar.items APIs - expose editor close lifecycle signaling for persisted/discarded/superseded flows Goal: enable add-ons to work with open editors (including unsaved items) without custom experiments.
Follow-up hardening for editor-context APIs: - bind editorId to concrete editor instances (tabId + editor outerWindowID) - reject stale tab editor instances during editorId resolution - remove global bridge registries in favor of per-extension bridge state - make calendar.items.updateCurrent transactional across fields and properties: - rollback fields on field failure - rollback applied properties and fields on property failure - align schema docs with the implemented contract (editor instance + transactional updateCurrent) This tightens long-term API contract behavior for dialog/tab editors, including unsaved items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposal improves editor-context handling for calendar add-ons in dialog and tab editors:
Goal: enable add-ons to work with open editors (including unsaved items) without custom experiments.