calendar: Various improvements to the calendar API

[kewisch]

Various improvements to the calendar API

Fixes #56 among others

[kewisch]

I'm going to go ahead and pile on commits here until you have time to review. If it becomes too big please do review each commit separately or tell me to stop.

[kewisch]

Commit 2958e9a replaces extensionCapabilities with overrideCapabilities. We only want to save values that have been overridden, otherwise if you have e.g. attachments: false in your manifest for 1.0 and attachments: true in 1.1 then it will still use attachments: false.

This will potentially break people who used the experiment and rely on the previous behavior, not sure if we want to indicate that in some way.

[jobisoft]

Commit 2958e9a replaces extensionCapabilities with overrideCapabilities. We only want to save values that have been overridden, otherwise if you have e.g. attachments: false in your manifest for 1.0 and attachments: true in 1.1 then it will still use attachments: false.

This will potentially break people who used the experiment and rely on the previous behavior, not sure if we want to indicate that in some way.

There are more changes in here, which may break add-ons, like the change from requires_network to requiresNetwork. Can we make a GitHub release to notify developers? Or just include the changes in the README?

[kewisch]

Hm yes I was wondering about this as well. I think if this repo would be our long term strategy then yes, let's have some sort of mechanism. On the other hand, developers will pull this code and copy it into their repo. If they are doing an update, I'm hoping they'll do a diff and see if they need to adapt.

I think I'd leave it as is for now, and at most add it to the README. Once we have the code in core we can use the normal deprecation mechanism to move forward.

[jobisoft]

Looks good to me. I do not claim to have understood everything, but feel confident to move forward.