Skip to content

Fix typo: 'transfered' -> 'transferred' in test tree file#703

Open
Zentex1337 wants to merge 1 commit intothirdweb-dev:mainfrom
Zentex1337:fix/typo-transferred-test-tree
Open

Fix typo: 'transfered' -> 'transferred' in test tree file#703
Zentex1337 wants to merge 1 commit intothirdweb-dev:mainfrom
Zentex1337:fix/typo-transferred-test-tree

Conversation

@Zentex1337
Copy link

@Zentex1337 Zentex1337 commented Feb 3, 2026

Summary

  • Fixed the misspelling of 'transferred' as 'transfered' in the _collectPriceOnClaim test tree documentation file
  • Fixed 8 occurrences of this typo

Test plan

  • No functional changes, only test documentation fix
  • Existing tests should continue to pass

Summary by CodeRabbit

  • Tests
    • Improved test clarity by correcting terminology in test expectations and standardizing assertion references to align with local parameter naming conventions.

Fixed the misspelling of 'transferred' as 'transfered' in the
_collectPriceOnClaim test tree documentation file (8 occurrences).
@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

Walkthrough

Updated test file with spelling corrections and parameter reference alignment. Changed "transfered" to "transferred" in test assertions and updated recipient references from primarySaleRecipient() to _primarySaleRecipient in specific test branches.

Changes

Cohort / File(s) Summary
Test file corrections
src/test/drop/drop-erc20/_collectPriceOnClaim/_collectPriceOnClaim.tree
Fixed spelling of "transferred" in test assertions and aligned recipient parameter references from function calls to local variable naming in not-native-token branches.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: fixing the typo 'transfered' to 'transferred' in the test tree file, which aligns with the changeset modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/test/drop/drop-erc20/_collectPriceOnClaim/_collectPriceOnClaim.tree (1)

33-38: ⚠️ Potential issue | 🟡 Minor

Pre-existing typo: Line 33 should say "when currency is native token".

This is outside the scope of your PR, but I noticed line 33 says "when currency is not native token" while its child on line 34 checks "when msg.value does not equal totalPrice" — a check that only applies to native tokens. Comparing to the parallel structure at lines 17-23, line 33 should read "when currency is native token" to be consistent.

Consider fixing this in a follow-up or in this PR if convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant