Fix typo: 'transfered' -> 'transferred' in test tree file#703
Fix typo: 'transfered' -> 'transferred' in test tree file#703Zentex1337 wants to merge 1 commit intothirdweb-dev:mainfrom
Conversation
Fixed the misspelling of 'transferred' as 'transfered' in the _collectPriceOnClaim test tree documentation file (8 occurrences).
WalkthroughUpdated test file with spelling corrections and parameter reference alignment. Changed "transfered" to "transferred" in test assertions and updated recipient references from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/test/drop/drop-erc20/_collectPriceOnClaim/_collectPriceOnClaim.tree (1)
33-38:⚠️ Potential issue | 🟡 MinorPre-existing typo: Line 33 should say "when currency is native token".
This is outside the scope of your PR, but I noticed line 33 says "when currency is not native token" while its child on line 34 checks "when msg.value does not equal totalPrice" — a check that only applies to native tokens. Comparing to the parallel structure at lines 17-23, line 33 should read "when currency is native token" to be consistent.
Consider fixing this in a follow-up or in this PR if convenient.
Summary
Test plan
Summary by CodeRabbit