Skip to content

audio: module-adapter: Fix SRC regression when ext_init dp_data present #10544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsarha wants to merge 1 commit into
base: main
Choose a base branch
from
Open

audio: module-adapter: Fix SRC regression when ext_init dp_data present #10544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/audio/module_adapter/module_adapter_ipc4.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ int module_adapter_init_data(struct comp_dev *dev,
}
}

if (!config->ipc_extended_init ||
(!dst->ext_data->dp_data && !dst->ext_data->module_data)) {
/* Assume legacy API if module data was not found in ext_init payload */
if (!dst->ext_data || !dst->ext_data->module_data) {
Copy link
Collaborator

@lyakh lyakh Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dst->ext_data cannot be NULL, right? Because of

sof/src/audio/module_adapter/module_adapter.c

Line 253 in 53f713a

dst->ext_data = &ext_data;

Copy link
Member

@lgirdwood lgirdwood Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like we can benefit from having some accessors around extended data types and existance that all modules and module infra can use.

dst->init_data = cfg; /* legacy API */
dst->avail = true;
}
Expand Down