fix: get_wrapped_container returns container all the time now

[alexanderankin]

fix #905

[alexanderankin]

ok, have to think about this one more carefully. seems like there is more to this than appears

[surister]

Suggested change

	def _get_docker_client(self) -> DockerClient:
	def _get_docker_client(self) -> DockerClient:
	if self._docker_client is None:
	self._docker_client = DockerClient(**(self.docker_client_kw or {}))
	return self._docker_client

[surister]

Dumb question: can .containers.get(self.ID) return a value other than Container, e.g. None?

what if the container is not found?

[alexanderankin]

it throws docker api exception or something. its in the docstr of the get method. just navigate to it and you should see it also

…

On Thu, Oct 16, 2025 at 8:58 AM Ivan ***@***.***> wrote: ***@***.**** approved this pull request. ------------------------------ In core/testcontainers/compose/compose.py <#906 (comment)> : > @@ -259,6 +263,13 @@ def compose_command_property(self) -> list[str]: docker_compose_cmd += ["--env-file", env_file] return docker_compose_cmd + def _get_docker_client(self) -> DockerClient: ⬇️ Suggested change - def _get_docker_client(self) -> DockerClient: + def _get_docker_client(self) -> DockerClient: + if self._docker_client is None: + self._docker_client = DockerClient(**(self.docker_client_kw or {})) + return self._docker_client ------------------------------ In core/testcontainers/compose/compose.py <#906 (comment)> : > """Get the underlying container object for compatibility.""" - return self + return self._docker_compose._get_docker_client().containers.get(self.ID) Dumb question: can .containers.get(self.ID) return a value other than Container, e.g. None? what if the container is not found? — Reply to this email directly, view it on GitHub <#906 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACECGJDPPFF3B2BECIZBBUD3X6I6RAVCNFSM6AAAAACJIPB3Z2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGNBUG4YTAMBUHA> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>

[jankatins]

❤️

[alexanderankin]

We recently had a PR that added a bunch of data classes, I think I should actually be returning one of those here