feat(modules): Add Cratedb container#888
Open
surister wants to merge 8 commits intotestcontainers:mainfrom
Open
feat(modules): Add Cratedb container#888surister wants to merge 8 commits intotestcontainers:mainfrom
surister wants to merge 8 commits intotestcontainers:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
surister
changed the title
|
LGTM, thanks a stack. I think the patch would be ready to go into final review. Thank you so much in advance and for your excellent work on this project, @Tranquility2 and @alexanderankin. |
Author
I think I'd rather wait for #892 to be merged so I can re-implement this with the new class, that way we can have something that hopefully we won't have to touch for a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add testcontainer for CrateDB, please when merging squash commits accordingly