Add Findings and Policy Findings API modules for Tenable OT Security#981
Open
ThisTooShallXSS wants to merge 1 commit intotenable:mainfrom
Open
Add Findings and Policy Findings API modules for Tenable OT Security#981ThisTooShallXSS wants to merge 1 commit intotenable:mainfrom
ThisTooShallXSS wants to merge 1 commit intotenable:mainfrom
Conversation
Implements comprehensive API support for managing security findings and policy compliance findings in OT environments. New API Modules: - FindingsAPI: Manages vulnerability findings detected on assets, including list operations with GraphQL support, filtering, sorting, and pagination - PolicyFindingsAPI: Manages policy violation and compliance findings with similar query capabilities Schema Definitions: - Created Pydantic schemas for data validation (findings.py, policy_findings.py) - Added GraphQL schema definitions for both findings types - Integrated comprehensive field mappings for asset details, plugin information, detection metadata, and status tracking GraphQL Integration: - Extended query.py with FINDINGS_QUERY and POLICY_FINDINGS_QUERY - Implemented OTGraphIterator support for efficient pagination - Added support for complex filtering, sorting, and search capabilities Testing: - Comprehensive test coverage for both API modules (774 total test lines) - Tests cover list operations, filtering, pagination, error handling, and schema validation Updated session.py to register new API endpoints and __init__.py to export new modules. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements comprehensive API support for managing security findings and policy compliance findings in OT environments.
Type of change
New API Modules:
Schema Definitions:
GraphQL Integration:
Testing:
Updated session.py to register new API endpoints and init.py to export new modules.
Please delete options that are not relevant.
Test Configuration: