Fix subtitle size and padding on proj nav #3148
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| class={merge('m-1', subtitle !== 'Cloud' && 'hidden')} | ||
| /> | ||
| {#if subtitle} | ||
| {#if subtitle === 'Cloud'} |
There was a problem hiding this comment.
Curious why this change is needed? We can just add additional conditions (e.g. subtitle !== 'Cloud' ? 'text-2xl' : 'text-lg') to merge() if needed, no?
There was a problem hiding this comment.
We needed additional padding on the smaller 'new nav' subtitle so that it aligns with the nav items. If this padding is on the old nav it makes the 'Cloud' word off centered.
I believe this change should have fixed the padding. Can you verify this is still happening on the latest?
There was a problem hiding this comment.
Like the font size, the padding is only needed on the 'new nav' and very much not needed on the 'old nav.'
It's all a bit messy with all these conditionals 😅.
I will switch to the tw Merge for both.
Co-authored-by: Laura Whitaker <laura.whitaker@temporal.io>
Auto-generated version bump from 2.45.2 to 2.45.3 Specific version: 2.45.3 Changes included: - [`8fcea7ea`](8fcea7e) fix(nav): restore cloud navigation width and version positioning (#3147) - [`9fd0b463`](9fd0b46) Refactor to use on from svelte/events (#3126) - [`c4cb8fa8`](c4cb8fa) Upgrade to ESLint v9 (#3125) - [`50d5c96c`](50d5c96) Fix subtitle size and padding on proj nav (#3148) - [`b06ca2fc`](b06ca2f) Update activity operator command API routes (#3151)
Auto-generated version bump from 2.45.2 to 2.45.3 Specific version: 2.45.3 Changes included: - [`8fcea7ea`](8fcea7e) fix(nav): restore cloud navigation width and version positioning (#3147) - [`9fd0b463`](9fd0b46) Refactor to use on from svelte/events (#3126) - [`c4cb8fa8`](c4cb8fa) Upgrade to ESLint v9 (#3125) - [`50d5c96c`](50d5c96) Fix subtitle size and padding on proj nav (#3148) - [`b06ca2fc`](b06ca2f) Update activity operator command API routes (#3151) Co-authored-by: laurakwhit <15069288+laurakwhit@users.noreply.github.com>
2 participants
Slight fix that does two things