Skip to content

DT-3411: Make tables full height with pagination at top #3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
andrewzamojc wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

DT-3411: Make tables full height with pagination at top #3130

andrewzamojc wants to merge 26 commits into from

Conversation

@andrewzamojc
Copy link
Contributor

@andrewzamojc andrewzamojc commented Feb 3, 2026

Summary

Makes tables grow naturally with content and adds pagination controls to both top and bottom of tables.

Changes

Core Table Component (index.svelte)

  • Made maxHeight optional: Keep prop for constrained contexts (accordions, modals) while allowing full-page tables to omit it
  • Removed height constraints: Eliminated min-h-[154px] and tableOffset calculation
  • Horizontal scrolling: Changed overflow-auto to overflow-x-auto
  • Top pagination: Added pagination bar above table content
  • Removed sticky positioning: Pagination now flows naturally with page scroll

Full-Page Table Updates

  • Workflows table: Removed maxHeight prop
  • Standalone activities table: Removed maxHeight prop

Behavior

Before

  • Tables had fixed min-height (154px) and max-height constraints
  • Small tables showed excessive white space
  • Pagination only at bottom
  • Internal table scrolling with sticky pagination

After

  • Tables sized by content (tiny with few rows, large with many rows)
  • Pagination at both top and bottom
  • Entire page scrolls naturally
  • Tables in constrained contexts (like event history) still respect maxHeight

Testing

  • TypeScript check passes (0 errors)
  • Linting passes
  • Tables with few rows are appropriately small
  • Tables with many rows scroll the entire page
  • Wide tables scroll horizontally
  • Constrained tables (event history) still work correctly

Notes

  • Event history table keeps maxHeight because it's used in a minimizable panel
  • This will work when imported into cloud-ui repo

rossedfort and others added 26 commits January 7, 2026 11:05
@rossedfort
DT-3531 - start standalone activity (#3074)
a5fecae 
* WIP - start standalone activity

* change routes, add duration input, fix imports

* use queryparams for initial form values

* clean up

- update go api module
- clean up api routes
- add placeholder page for activity execution details
- add support for query params to pre-fill form

* add page components

* add integration tests
@rossedfort
Merge branch 'main' into standalone-activities
666e2a5
@rossedfort
DT-3526 describe standalone activity (#3099)
1653ac9 
* standalone activity details

* decode and refactor

* clean up

* clean up

* add page titles

* add default param

* remove pause, update and reset buttons

* fix pnpm lock

* add error state

* increase toast duration
@Alex-Tideman
Standalone Activities List (#3103)
70c49c5 
* Add standalone activities UI

* Upgrade to svelte5

* Don't allow onclick on button until we migrate it to Svelte5

* Remove batch functionality

* Fix up some table stuff

* Add filterable/copiable cells

* Add Start Activity Like this One
@rossedfort
DT-3532 - activity execution actions (#3115)
e6da300 
* add terminate and cancel to activity details page

* update api
@rossedfort
Merge branch 'main' into standalone-activities
205ff7f
@rossedfort
add disabled state for standalone activities (#3122)
fb800a6
@rossedfort
Standalone activities design scrub (#3123)
e1ec090 
* design scrub

* fix i18n

* rename and reorganize

* fix poller
@rossedfort
Merge branch 'main' into standalone-activities
f0f534b
@rossedfort
fix test
9656864
@rossedfort
fix test
17653e3
@rossedfort
add alert for when no workers
e712796
@rossedfort
404 standalone activities for now
c5b682d
@rossedfort
refetch activity after terminate and cancel
adb3ba8
@rossedfort
add search attributes for filters
8939e4e
@rossedfort
fix duration input dark mode
09d6c14
@rossedfort
add fallback values for activity header
3c97e6a
@rossedfort
remove postscss
f0af030
@rossedfort
better way to do search attributes
d589454
@rossedfort
fix screaming enums
3288165
@rossedfort
trigger actions
07b9937
@rossedfort
bump api version to v1.62.0
0b47388
@rossedfort
fix some strict mode
8a53f4a
@rossedfort
fix some more strict
7b11111
@andrewzamojc
Make table maxHeight optional and remove default constraints
0544e5c 
- Keep maxHeight prop for constrained contexts (accordions, etc)
- Remove hardcoded tableOffset calculation
- Remove min-h-[154px] constraint
- Change overflow-auto to overflow-x-auto for horizontal scrolling
- Remove sticky positioning from pagination
@andrewzamojc
Remove maxHeight from full-page table usages
8668018 
- Remove maxHeight from workflows summary table
- Remove maxHeight from activities summary table
- These tables should grow naturally with content
@vercel
Copy link

vercel bot commented Feb 3, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Feb 3, 2026 9:31pm

Request Review

@bilal-karim
Copy link
Member

bilal-karim commented Feb 4, 2026

Can I get a Cloud preview URL of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alex-Tideman Alex-Tideman Awaiting requested review from Alex-Tideman Alex-Tideman will be requested when the pull request is marked ready for review Alex-Tideman is a code owner

@rossedfort rossedfort Awaiting requested review from rossedfort rossedfort will be requested when the pull request is marked ready for review rossedfort is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewzamojc @bilal-karim @rossedfort @Alex-Tideman