feat(syncer-service): onboard syncer-service component#3198
feat(syncer-service): onboard syncer-service component#3198ab-ghosh wants to merge 1 commit intotektoncd:mainfrom
Conversation
tekton-robot
added
the
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/XXL
|
Upgrade test results: Before the upgrade After the upgrade Updating the TektonConfig with the scheduler configuration (multi-cluster-disabled: false and multi-cluster-role: Hub) 
Updating the TektonConfig with the scheduler configuration (multi-cluster-disabled: true and multi-cluster-role: "") |
ab-ghosh
force-pushed
the
onboard-syncer-service-upstream
branch
from
77a2861 to
0d89eb4
Compare
|
@ab-ghosh - Thanks for sharing the outcome of upgrade tests. Please includes tests to make sure that sync service behaves the expected way in hub and spoke cluster. Check the possibility incorporating tests in the following one atleast for each type : locations: https://github.com/tektoncd/operator/tree/main/test Also see the possibility of incorporating unit tests. |
| // Syncer-service is enabled when: | ||
| // 1. Multi-cluster is NOT disabled (i.e., multi-cluster is enabled) | ||
| // 2. The role is Hub | ||
| func IsSyncerServiceEnabled(scheduler *v1alpha1.Scheduler) bool { |
ab-ghosh
force-pushed
the
onboard-syncer-service-upstream
branch
from
0d89eb4 to
4014bda
Compare
Add conditional deployment of syncer-service based on TektonConfig: - scheduler.multi-cluster-disabled: false - scheduler.multi-cluster-role: Hub Includes CRD, controllers, reconcilers for Kubernetes and OpenShift. Signed-off-by: ab-ghosh <abghosh@redhat.com>
ab-ghosh
force-pushed
the
onboard-syncer-service-upstream
branch
from
4014bda to
fc75dd3
Compare
|
/kind feature |
tekton-robot
added
the
kind/feature
khrm
left a comment
khrm
left a comment
There was a problem hiding this comment.
Looks good. But shouldn't we keep this to only OpenShift, like PAC?
|
|
||
| SyncerService custom resource allows user to install and manage [Syncer Service][SyncerService]. | ||
|
|
||
| Syncer Service is a Kubernetes controller that synchronizes secrets between manager (hub) and worker (spoke) nodes in multi-Kueue environments. It enables seamless multi-cluster pipeline execution by ensuring PipelineRuns have the necessary authentication secrets available on their target clusters. |
There was a problem hiding this comment.
can we add a doc reference to multi-Kueue environments which can provide few details about the multi-kueue/mult-kueue environments?
| "existingNamespace", installerSetTargetNamespace, | ||
| "newNamespace", ss.Spec.TargetNamespace) | ||
| err := r.operatorClientSet.OperatorV1alpha1().TektonInstallerSets(). | ||
| Delete(ctx, existingInstallerSet, metav1.DeleteOptions{}) |
There was a problem hiding this comment.
Could we move the delete operation into a separate function for better separation of concerns?
tekton-robot
added
the
needs-rebase
|
@ab-ghosh: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
Changes
This PR onboards the syncer-service component into the Tekton Operator with conditional deployment based on TektonConfig scheduler settings.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes