BF: fix memory leak for uncompressed .trx files#109
Merged
arokem merged 1 commit intotee-ar-ex:masterfrom Mar 5, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #109 +/- ##
==========================================
+ Coverage 61.50% 61.64% +0.14%
==========================================
Files 13 13
Lines 2613 2623 +10
==========================================
+ Hits 1607 1617 +10
Misses 1006 1006
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
Collaborator
|
LGTM! @frheault (or others) : I would really appreciate another set of eyes, if you have the bandwidth. |
frheault
approved these changes
Mar 5, 2026
Collaborator
frheault
left a comment
There was a problem hiding this comment.
I'm happy it seems like past me thought about it, but I was just bad at it !
Thank you for the fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108
This pull request updates the resource cleanup logic for memory-mapped files in the
trxpackage and adds a new test to ensure proper handle release. The main improvement is thatclose()will always release mmap handles, even when loaded from a zip file, regardless of the presence of an uncompressed folder handle.