Skip to content

BF: fix memory leak for uncompressed .trx files#109

Merged
arokem merged 1 commit intotee-ar-ex:masterfrom
skoudoro:fix-leaks
Mar 5, 2026
Merged

BF: fix memory leak for uncompressed .trx files#109
arokem merged 1 commit intotee-ar-ex:masterfrom
skoudoro:fix-leaks

Conversation

@skoudoro
Copy link
Collaborator

@skoudoro skoudoro commented Mar 4, 2026

Fixes #108

This pull request updates the resource cleanup logic for memory-mapped files in the trx package and adds a new test to ensure proper handle release. The main improvement is that close() will always release mmap handles, even when loaded from a zip file, regardless of the presence of an uncompressed folder handle.

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.64%. Comparing base (4bdd8a8) to head (df7e7d3).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   61.50%   61.64%   +0.14%     
==========================================
  Files          13       13              
  Lines        2613     2623      +10     
==========================================
+ Hits         1607     1617      +10     
  Misses       1006     1006              
Flag Coverage Δ
unittests 61.64% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@skoudoro skoudoro requested review from arokem and frheault March 4, 2026 15:40
@skoudoro skoudoro mentioned this pull request Mar 4, 2026
@arokem
Copy link
Collaborator

arokem commented Mar 5, 2026

LGTM! @frheault (or others) : I would really appreciate another set of eyes, if you have the bandwidth.

Copy link
Collaborator

@frheault frheault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy it seems like past me thought about it, but I was just bad at it !

Thank you for the fix

@arokem arokem merged commit c1385d6 into tee-ar-ex:master Mar 5, 2026
16 checks passed
@skoudoro skoudoro deleted the fix-leaks branch March 5, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

memory leak for uncompressed .trx files.

3 participants