jextract/jni: Basic accept/return support for Swift tuples#602
Draft
ktoso wants to merge 3 commits intoswiftlang:mainfrom
Draft
jextract/jni: Basic accept/return support for Swift tuples#602ktoso wants to merge 3 commits intoswiftlang:mainfrom
ktoso wants to merge 3 commits intoswiftlang:mainfrom
Conversation
ktoso
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for returning and accepting tuples in jextract/jni.
We implement this by passing single element arrays as indirect results into which the thunks initialize the values.
I somehow super messed up my local gradle config so didn't verify the sample :| I'm working on figuring what happened...
resolves #596
Disclosure: boilerplate and general structure was generated using claude code. I have fully reviewed and polished up the output to a standard I deem acceptable for the project. The way we handle the out parameters is good as well, the array trick is good for these one off parameters of potentially different types. We could optimize this if we notice the tuple is of the same type and just use a single array then etc.