Skip to content

Add PR Dependency check workflow#233

Open
bkhouri wants to merge 2 commits intoswiftlang:mainfrom
bkhouri:t/main/pr_dependency-check
Open

Add PR Dependency check workflow#233
bkhouri wants to merge 2 commits intoswiftlang:mainfrom
bkhouri:t/main/pr_dependency-check

Conversation

@bkhouri
Copy link
Contributor

@bkhouri bkhouri commented Jan 28, 2026

While working on a project, I tend to build one PR on top of another. And although The later PR can be merged and include all the child PR, it's not ideal as it can lead to the "parent" PR being closed without having any references to approval - as the approvals were given in a child PR.

Sometimes SwiftPM PR's are depend on a change in https://github.com/swiftlang/swift-build, or even changes in https://github.com/swiftlang/swift

Here's are examples of the two scenarios:

@bkhouri bkhouri force-pushed the t/main/pr_dependency-check branch from 28da7c7 to 6f41ed3 Compare January 28, 2026 17:00
@bkhouri bkhouri marked this pull request as ready for review January 28, 2026 17:08
@bkhouri bkhouri requested a review from a team as a code owner January 28, 2026 17:08
@bkhouri bkhouri marked this pull request as draft January 28, 2026 18:25
@bkhouri bkhouri marked this pull request as ready for review March 3, 2026 19:27
@bkhouri bkhouri marked this pull request as draft March 3, 2026 19:27
@bkhouri
Copy link
Contributor Author

bkhouri commented Mar 3, 2026

Closing this PR as there is an existing GitHub Action: https://github.com/gregsdennis/dependencies-action

@bkhouri bkhouri force-pushed the t/main/pr_dependency-check branch 4 times, most recently from b4ce1a7 to 875a34f Compare March 10, 2026 13:15
@bkhouri bkhouri force-pushed the t/main/pr_dependency-check branch from 875a34f to 71643ce Compare March 10, 2026 13:17
@bkhouri bkhouri marked this pull request as ready for review March 10, 2026 15:30
@bkhouri bkhouri force-pushed the t/main/pr_dependency-check branch from bfc25a8 to b88cd06 Compare March 11, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants