Open
Conversation
Signed-off-by: Dan K. Snelson <24623109+dan-snelson@users.noreply.github.com>
Introduce a new self-contained Inspect Mode demo script and connect it to
the existing demo controller and public documentation.
Why:
- The suite previously excluded `--inspect-mode` / `--inspect-config`.
- We now want a first-draft, deterministic Inspect Mode walkthrough that
matches the style and flow of demos 01–18.
What changed:
- Added `demos/19_inspect_mode.zsh`
- Uses a generated JSON config at runtime.
- Launches Inspect Mode with:
`DIALOG_INSPECT_CONFIG=... dialog --inspect-mode --inspect-config ...`
- Demonstrates key config areas:
- `preset`
- `logMonitor` (`path`, `preset`, `autoMatch`, `startFromEnd`)
- `sideMessage` / `sideInterval`
- `items` with deterministic `/tmp` paths
- `autoEnableButton` / `autoEnableButtonText`
- Simulates install progression by appending log lines and creating item
paths under `/tmp/swiftdialog_inspect_mode_items`.
- Includes cleanup via `trap` for temp files/directories.
- Updated `run_demos.zsh`
- Added selector checkbox:
`19. Inspect Mode (config presets - log monitor - item auto-complete)`
- Added `demo_map` entry to run `19_inspect_mode.zsh`.
- Increased selector height from `650` to `690` for layout headroom.
- Updated `README.md`
- Added Demo 19 entry to the Demo Index table.
- Replaced the old note saying inspect mode is excluded with a note
describing Demo 19 coverage and linking to Inspect Mode docs.
Implementation notes:
- Kept `demos/Microsoft 365 Install (1.0.0a2).zsh` untouched as reference.
- Added `guiIndex` for each item and explicit `--inspect-config` to ensure
the custom config loads reliably instead of falling back to built-in
preset onboarding.
Validation performed:
- `zsh -n demos/19_inspect_mode.zsh`
- Manual run of `zsh demos/19_inspect_mode.zsh` with expected Inspect Mode
config load behavior.
- Manual visual verification of first-draft UI flow.
Signed-off-by: Dan K. Snelson <24623109+dan-snelson@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This pull request introduces Demo 19 to showcase swiftDialog's Inspect Mode functionality, which was previously excluded from the demo suite. The demo creates a self-contained, deterministic simulation that demonstrates config-driven progress monitoring through JSON configuration, log file monitoring, and path-based item completion tracking.
Changes:
- Added Demo 19 Inspect Mode with runtime-generated JSON config demonstrating presets, logMonitor, sideMessage, items, and autoEnableButton
- Integrated Demo 19 into the demo suite controller with checkbox selector and demo map entry
- Updated documentation to reflect Demo 19 inclusion and fixed typo in README
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
demos/19_inspect_mode.zsh |
New self-contained demo script that generates Inspect Mode JSON config at runtime, simulates install progression using temporary paths in /tmp, and demonstrates key Inspect Mode features with proper cleanup via trap |
run_demos.zsh |
Added Demo 19 checkbox to selector UI, added corresponding demo_map entry, and increased selector height from 650 to 690 to accommodate the new entry |
README.md |
Added Demo 19 entry to the demo index table and updated the notes section to describe Demo 19 coverage instead of stating Inspect Mode is excluded (also removes the typo "dilaog") |
.gitignore |
Added comprehensive gitignore file with standard macOS ignores, zsh-specific files, project temporary files, and local guidance documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Demo 19 Inspect Mode and wire it into the demo suite
Introduce a new self-contained Inspect Mode demo script and connect it to
the existing demo controller and public documentation.
Why:
--inspect-mode/--inspect-config.matches the style and flow of demos 01–18.
What changed:
Added
demos/19_inspect_mode.zshDIALOG_INSPECT_CONFIG=... dialog --inspect-mode --inspect-config ...presetlogMonitor(path,preset,autoMatch,startFromEnd)sideMessage/sideIntervalitemswith deterministic/tmppathsautoEnableButton/autoEnableButtonTextpaths under
/tmp/swiftdialog_inspect_mode_items.trapfor temp files/directories.Updated
run_demos.zsh19. Inspect Mode (config presets - log monitor - item auto-complete)demo_mapentry to run19_inspect_mode.zsh.650to690for layout headroom.Updated
README.mddescribing Demo 19 coverage and linking to Inspect Mode docs.
Implementation notes:
demos/Microsoft 365 Install (1.0.0a2).zshuntouched as reference.guiIndexfor each item and explicit--inspect-configto ensurethe custom config loads reliably instead of falling back to built-in
preset onboarding.
Validation performed:
zsh -n demos/19_inspect_mode.zshzsh demos/19_inspect_mode.zshwith expected Inspect Modeconfig load behavior.