Open
Conversation
Signed-off-by: Dan K. Snelson <24623109+dan-snelson@users.noreply.github.com>
The YouTube dialog message stated swiftDialog supports YouTube, Vimeo, and files/URLs but only YouTube was ever demonstrated. Adds a new '--- Video from Vimeo ---' section using vimeoid= shortcut syntax, consistent with the existing YouTube shortcut pattern.
There was a problem hiding this comment.
Pull request overview
This PR adds a Vimeo video demonstration section to the web video demo script, showing how to embed Vimeo videos using the vimeoid=<id> shortcut syntax. The PR also includes an unrelated .gitignore file addition.
Changes:
- Added a new Vimeo video playback section to demo 15, positioned between YouTube and autoplay sections
- Included a complete
.gitignorefile with macOS, Zsh, and project-specific ignore patterns (not mentioned in PR description)
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| demos/15_web_video.zsh | Adds a Vimeo video section demonstrating the vimeoid= shortcut, following the same structure as the YouTube section |
| .gitignore | Adds a comprehensive .gitignore file with patterns for macOS, Zsh, and project-specific temporary files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
# --- Video from Vimeo ---section between the YouTube and autoplay sections, demonstrating thevimeoid=<id>shortcut syntaxNext →/Skip/|| exit 0so the demo flows into the autoplay sectionTest plan
zsh -n demos/15_web_video.zshpasses silently (run as repo owner)