demo(09): add icon checkbox style; print switch output#3
Open
dan-snelson wants to merge 2 commits intoswiftDialog:mainfrom
Open
demo(09): add icon checkbox style; print switch output#3dan-snelson wants to merge 2 commits intoswiftDialog:mainfrom
dan-snelson wants to merge 2 commits intoswiftDialog:mainfrom
Conversation
Signed-off-by: Dan K. Snelson <24623109+dan-snelson@users.noreply.github.com>
The header listed 'icon' as a --checkboxstyle value but it was never demonstrated. Adds a new '--- Icon style ---' section. Also: switch style and switch sizes dialogs captured result but never printed it. Both now echo output through jq. Switch sizes changed from the terminal dialog to a mid-flow step (Next → / Skip), with the new icon style dialog becoming the final step (Done ✓).
There was a problem hiding this comment.
Pull request overview
This PR enhances the checkbox demo script by completing missing output printing and adding a new demonstration of the icon checkbox style. The changes ensure consistency with other demo scripts in the repository by following established patterns for output display and error handling.
Changes:
- Adds output printing for the Switch Style section that was previously missing
- Updates the Switch Sizes section to include proper button configuration and output printing
- Introduces a new Icon style section demonstrating
--checkboxstyle "icon"with three example checkboxes
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| demos/09_checkboxes.zsh | Adds missing output printing for Switch Style and Switch Sizes sections, and introduces a new Icon style demonstration section |
| .gitignore | Adds a comprehensive .gitignore file for macOS, Zsh, and project-specific temporary files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
echo "$result" | jq '.'so the captured JSON is actually printedNext →/Skip/|| exit 0(consistent intermediate-step pattern) and prints its output# --- Icon style ---section demonstrating--checkboxstyle "icon"Test plan
zsh -n demos/09_checkboxes.zshpasses silently (run as repo owner)