feat: added querying historical data by block range #2906
Open
Gmin2 wants to merge 1 commit intosubquery:mainfrom
Open
feat: added querying historical data by block range #2906Gmin2 wants to merge 1 commit intosubquery:mainfrom
Gmin2 wants to merge 1 commit intosubquery:mainfrom
Conversation
Contributor
Author
|
@stwiname can i get a review on this ? |
Collaborator
|
@Gmin2, it's on my radar, i just havent found the time for it |
Contributor
Author
|
Hey @stwiname I need to discuss somethings with yu can yu give me your tele or any social where i can dm yu |
Collaborator
stwiname
reviewed
Sep 17, 2025
Collaborator
stwiname
left a comment
There was a problem hiding this comment.
Hi @Gmin2, sorry for the delay reviewing this.
This is looking really good and on the right track. I've just got high level comments for now.
- The historical snapshot data looks to be missing the block range now
- It would be good for your PR description to include some more details on what needs to be done still and any concerns or unknowns
- I had a quick play around with some block range queries and the responses aren't updated
- A single entity query still returns a single result
- A multi entity query filtered to a single id returns multiple results but it doesn't include the block data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added querying historical data by block range
Fixes #1887
Type of change
Please delete options that are not relevant.
Checklist