Skip to content

Comments

Increase CURRENT DEVELOPMENT ENVIRONMENT to Fedora 42#330

Merged
mulkieran merged 2 commits intostratis-storage:masterfrom
mulkieran:issue_project_805
Nov 4, 2025
Merged

Increase CURRENT DEVELOPMENT ENVIRONMENT to Fedora 42#330
mulkieran merged 2 commits intostratis-storage:masterfrom
mulkieran:issue_project_805

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Oct 23, 2025

@mulkieran mulkieran self-assigned this Oct 23, 2025
@mulkieran mulkieran moved this to Pending in 2025October Oct 23, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 23, 2025

Walkthrough

Updated development environment image from Fedora 41 to Fedora 42 in GitHub Actions workflow and added Python 3.12 minimum version requirement to package configuration. No logic or functional changes introduced.

Changes

Cohort / File(s) Change Summary
CI/CD Environment Update
\\.github/workflows/main.yml
Bumped base container image from fedora:41 to fedora:42 across three matrix entries for linting, formatting, and yamllint tasks
Package Configuration
setup.cfg
Added [options] section with python_requires = >=3.12 to enforce minimum Python version during build/install

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Environment version bump is repetitive and cosmetic across three identical entries
  • Python version requirement is a single-line addition with no conditional logic

Poem

🐰 Fedora grows from forty-one to forty-two,
While Python spreads its wings anew,
Version constraints keep order true,
Updates light, and changes few!

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the primary change in the changeset—updating the development environment image from Fedora 41 to Fedora 42 in the GitHub Actions workflow.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0cdecc3 and 7692c17.

📒 Files selected for processing (2)
  • .github/workflows/main.yml (1 hunks)
  • setup.cfg (1 hunks)
🔇 Additional comments (2)
.github/workflows/main.yml (1)

35-35: The fedora:42 container image is available and stable; CI verification will occur automatically when the PR is processed.

The update to fedora:42 across all matrix entries (lines 35, 40, 44) is consistent and correct. Fedora 42 was released on April 15, 2025, and the fedora:42 Docker image is available on Docker Hub. The workflow configuration is valid—GitHub Actions will automatically pull the container image when the workflow runs. The actual CI job success will be verified when GitHub Actions processes this PR.

setup.cfg (1)

9-10: No action required.

Fedora 42 ships Python 3.13, which satisfies the python_requires = >=3.12 constraint specified in setup.cfg. The package requirement and CI environment are compatible.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mulkieran mulkieran marked this pull request as ready for review November 4, 2025 20:15
@mulkieran mulkieran moved this from Pending to In Review in 2025October Nov 4, 2025
the Mulhern added 2 commits November 4, 2025 15:16
Signed-off-by: the Mulhern <amulhern@amulhern.bos.csb>
Signed-off-by: the Mulhern <amulhern@amulhern.bos.csb>
@mulkieran mulkieran merged commit a5c3117 into stratis-storage:master Nov 4, 2025
5 checks passed
@mulkieran mulkieran deleted the issue_project_805 branch November 4, 2025 23:07
@github-project-automation github-project-automation bot moved this from In Review to Done in 2025October Nov 4, 2025
@mulkieran mulkieran moved this from Done to Done(5) in 2025October Nov 17, 2025
@mulkieran mulkieran removed this from 2025October Nov 17, 2025
@mulkieran mulkieran moved this from Done to Done(1) in 2025November Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done(1)

Development

Successfully merging this pull request may close these issues.

1 participant