Skip to content

Comments

Increase GitHub Action checkout version to v5#329

Merged
mulkieran merged 3 commits intostratis-storage:masterfrom
mulkieran:issue_project_807
Aug 20, 2025
Merged

Increase GitHub Action checkout version to v5#329
mulkieran merged 3 commits intostratis-storage:masterfrom
mulkieran:issue_project_807

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Aug 19, 2025

Related stratis-storage/project#807

Summary by CodeRabbit

  • Chores
    • Updated CI checkout action to the latest version for improved reliability.
    • Hardened workflow security by preventing credentials from persisting across steps.
    • Reordered workflow steps so source checkout runs after dependencies are installed.
    • Added git to the list of installed dependencies in the workflow.

Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran self-assigned this Aug 19, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 19, 2025

Walkthrough

The GitHub Actions workflow was modified: the checkout action was bumped from actions/checkout@v4 to actions/checkout@v5 with persist-credentials: false; the checkout step was moved to occur after dependency installation; and git was added to installed dependencies.

Changes

Cohort / File(s) Summary
CI workflow
.github/workflows/main.yml
Reordered steps so dependencies are installed before checkout; added git to installed packages; updated actions/checkout@v4actions/checkout@v5 and set with: persist-credentials: false on the checkout step.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Runner as GitHub Runner
  participant Packages as Package Manager
  participant Checkout as actions/checkout
  participant Steps as Remaining Steps

  rect rgb(235,245,255)
    Note over Runner,Packages: New flow (this PR)
    Runner->>Packages: install dependencies (includes git)
    Packages-->>Runner: deps installed
    Runner->>Checkout: checkout repo (v5, persist-credentials: false)
    Checkout-->>Runner: repo checked out
    Runner->>Steps: run remaining workflow steps
  end

  rect rgb(255,245,235)
    Note over Runner,Checkout: Old flow (before PR)
    Runner->>Checkout: checkout repo (v4, default creds)
    Checkout-->>Runner: repo checked out
    Runner->>Packages: install dependencies (no explicit git)
    Packages-->>Runner: deps installed
    Runner->>Steps: run remaining workflow steps
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

Poem

Hop, hop! I tweak the gears,
I add a step and swap a tag,
Git joins the party, then I fetch the code,
v5 arrives — credentials bagged.
CI hums; the burrow wags its tail. 🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 642908d and a19db07.

📒 Files selected for processing (1)
  • .github/workflows/main.yml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/main.yml
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/main.yml (2)

50-51: Good hardening: persist-credentials: false. Add least-privilege permissions at the workflow level.

This is a solid security improvement. Since the job doesn’t push or require elevated repo permissions, consider adding a top-level permissions block to restrict the GITHUB_TOKEN further.

You can add (outside this hunk) near the top-level:

permissions:
  contents: read

49-49: Verify runner compatibility and consider pinning actions/checkout@v5

Actions/checkout@v5 is now generally available (v5.0.0) and introduces a minimum runner requirement. To finalize:

• Confirm your GitHub Actions runners are at least v2.327.1 — workflows on older runners will fail under v5.
• (Optional) Pin to the v5.0.0 commit SHA for supply-chain hardening:

.github/workflows/main.yml (line 49)

-      - uses: actions/checkout@v5
+      - uses: actions/checkout@08c69039cf31b682801d6812fc4761eba6be010e
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e1456e8 and 642908d.

📒 Files selected for processing (1)
  • .github/workflows/main.yml (1 hunks)
🔇 Additional comments (1)
.github/workflows/main.yml (1)

49-51: Ensure Git is available in the fedora:41 container

I searched all workflows and did not find any existing step installing Git before the checkout:

  • .github/workflows/main.yml:49-51 uses actions/checkout@v5 without a prior Git install.

Because container jobs run entirely inside the specified image, the checkout action will fail if Git isn’t present. Please either:

• Confirm that the official fedora:41 image already includes Git at runtime
• Or add an install step before checkout, for example:

- name: Install Git
  run: dnf install -y git
- uses: actions/checkout@v5
  with:
    persist-credentials: false

It can do more things if the command-line tool is available

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran moved this to In Review in 2025August Aug 20, 2025
@mulkieran
Copy link
Member Author

There was a disruption of GitHub services. I'm going to bet this is correct. If not, it's easy enough to revert.

@mulkieran mulkieran merged commit daa9fe9 into stratis-storage:master Aug 20, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In Review to Done in 2025August Aug 20, 2025
@mulkieran mulkieran deleted the issue_project_807 branch August 20, 2025 02:28
@mulkieran mulkieran moved this from Done to Done(3) in 2025August Aug 25, 2025
@mulkieran mulkieran added this to the v3.9.0 milestone Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done(3)

Development

Successfully merging this pull request may close these issues.

1 participant