Increase GitHub Action checkout version to v5#329
Increase GitHub Action checkout version to v5#329mulkieran merged 3 commits intostratis-storage:masterfrom
Conversation
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
WalkthroughThe GitHub Actions workflow was modified: the checkout action was bumped from actions/checkout@v4 to actions/checkout@v5 with persist-credentials: false; the checkout step was moved to occur after dependency installation; and Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Runner as GitHub Runner
participant Packages as Package Manager
participant Checkout as actions/checkout
participant Steps as Remaining Steps
rect rgb(235,245,255)
Note over Runner,Packages: New flow (this PR)
Runner->>Packages: install dependencies (includes git)
Packages-->>Runner: deps installed
Runner->>Checkout: checkout repo (v5, persist-credentials: false)
Checkout-->>Runner: repo checked out
Runner->>Steps: run remaining workflow steps
end
rect rgb(255,245,235)
Note over Runner,Checkout: Old flow (before PR)
Runner->>Checkout: checkout repo (v4, default creds)
Checkout-->>Runner: repo checked out
Runner->>Packages: install dependencies (no explicit git)
Packages-->>Runner: deps installed
Runner->>Steps: run remaining workflow steps
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/main.yml (2)
50-51: Good hardening: persist-credentials: false. Add least-privilege permissions at the workflow level.This is a solid security improvement. Since the job doesn’t push or require elevated repo permissions, consider adding a top-level permissions block to restrict the GITHUB_TOKEN further.
You can add (outside this hunk) near the top-level:
permissions: contents: read
49-49: Verify runner compatibility and consider pinning actions/checkout@v5Actions/checkout@v5 is now generally available (v5.0.0) and introduces a minimum runner requirement. To finalize:
• Confirm your GitHub Actions runners are at least v2.327.1 — workflows on older runners will fail under v5.
• (Optional) Pin to the v5.0.0 commit SHA for supply-chain hardening:.github/workflows/main.yml (line 49)
- - uses: actions/checkout@v5 + - uses: actions/checkout@08c69039cf31b682801d6812fc4761eba6be010e
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/main.yml(1 hunks)
🔇 Additional comments (1)
.github/workflows/main.yml (1)
49-51: Ensure Git is available in the fedora:41 containerI searched all workflows and did not find any existing step installing Git before the checkout:
.github/workflows/main.yml:49-51usesactions/checkout@v5without a prior Git install.Because container jobs run entirely inside the specified image, the checkout action will fail if Git isn’t present. Please either:
• Confirm that the official
fedora:41image already includes Git at runtime
• Or add an install step before checkout, for example:- name: Install Git run: dnf install -y git - uses: actions/checkout@v5 with: persist-credentials: false
It can do more things if the command-line tool is available Signed-off-by: mulhern <amulhern@redhat.com>
|
There was a disruption of GitHub services. I'm going to bet this is correct. If not, it's easy enough to revert. |
Related stratis-storage/project#807
Summary by CodeRabbit