Open
Conversation
mehtarac
requested a deployment
to
manual-approval
GitHub Actions
Waiting
mehtarac
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
pgrayy
reviewed
Feb 17, 2026
| import sys | ||
|
|
||
| if sys.version_info < (3, 12): | ||
| raise ImportError("BidiNovaSonicModel is only supported for Python 3.12+") |
zastrowm
approved these changes
Feb 17, 2026
| from .events import BidiAudioInputEvent, BidiImageInputEvent, BidiTextInputEvent | ||
|
|
||
| BidiAgentInput: TypeAlias = str | BidiTextInputEvent | BidiAudioInputEvent | BidiImageInputEvent | ||
| type BidiAgentInput = str | BidiTextInputEvent | BidiAudioInputEvent | BidiImageInputEvent |
Member
There was a problem hiding this comment.
Do we know if this has any practical difference in behavior? If not, I'm okay with it
pgrayy
reviewed
Feb 17, 2026
| try: | ||
| message = await asyncio.wait_for(self._websocket.recv(), timeout=10) | ||
| except asyncio.TimeoutError: | ||
| except TimeoutError: |
Member
There was a problem hiding this comment.
I think we still need to keep asyncio.TimeoutError for python 3.10.
pgrayy
reviewed
Feb 17, 2026
| from .events import BidiAudioInputEvent, BidiImageInputEvent, BidiTextInputEvent | ||
|
|
||
| BidiAgentInput: TypeAlias = str | BidiTextInputEvent | BidiAudioInputEvent | BidiImageInputEvent | ||
| type BidiAgentInput = str | BidiTextInputEvent | BidiAudioInputEvent | BidiImageInputEvent |
Member
There was a problem hiding this comment.
I don't think this is valid 3.10 syntax. I guess this highlights that hatch run bidi:prepare still has issues.
#1297
^ This PR will fix all that and have the bidi code checked under hatch run prepare. We need to get the pyaudio import situation worked out first though.
JackYPCOnline
approved these changes
Feb 17, 2026
afarntrog
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix bidi linting errors
Related Issues
Documentation PR
Type of Change
Bug fix
New feature
Breaking change
Documentation update
Other (please describe):
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run bidi:prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.