fixed a rare case where assets urls are created invalid#35
Closed
vannidellaricca wants to merge 1 commit intostellarwp:mainfrom
Closed
fixed a rare case where assets urls are created invalid#35vannidellaricca wants to merge 1 commit intostellarwp:mainfrom
vannidellaricca wants to merge 1 commit intostellarwp:mainfrom
Conversation
Member
|
@vannidellaricca thank you for this PR. I would love to see us have a Test set for this @dpanta94 before we merge. Not 100% a priority but worth the time after we finish Tyson. |
Contributor
Author
|
Hi, |
Member
|
Hey @vannidellaricca i took over your PR in #46. I'm sorry for the delay here, this is something im ashamed for. I could say that there was a ton of work and that didnt fit my schedule, but it wouldn't an honest response. The truth is this slipped from my attention. We will be taking care of it though now! |
Member
|
Ill be closing this PR over the new one. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
we found an rare case in which library return an invalid url.
some preconditions:
which this condition in file Config.php on method get_url the function str_replace trigger the transformation many time for the string.
this is te our test env
wp_list_pluck( $bases, 'base_dir' ) return
wp_list_pluck( $bases, 'base_url' ) return
the transformation return
http:/http:/http://miodominiouno.it/ita/wp-content/plugins/the-events-calendar/common/we have made a test using strtr that perform only one substitution and the code works.
We attach a 1 line patch