feat: add `lapack/base/dgetc2` #10071

prajjwalbajpai · 2026-02-03T16:56:49Z

Description

What is the purpose of this pull request?

This pull request:

adds lapack/base/dgetc2

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

NA

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

stdlib-bot · 2026-02-03T16:59:21Z

Coverage Report

Package	Statements	Branches	Functions	Lines
lapack/base/dgetc2	$\color{green}458/458$ $\color{green}+0.00%$	$\color{green}38/38$ $\color{green}+0.00%$	$\color{green}3/3$ $\color{green}+0.00%$	$\color{green}458/458$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

kgryte · 2026-02-03T17:53:34Z

lib/node_modules/@stdlib/lapack/base/dgetc2/lib/base.js

+			A[ oA + ( j*sA1 ) + ( i*sA2 ) ] /= A[ oA + ( i*( sA1 + sA2 ) ) ];
+		}
+
+		dger.ndarray( N - i-1, N - i-1, -1, A, sA1, oA + ( ( i + 1 )*sA1 ) + ( i*sA2 ), A, sA2, oA + ( i*sA1 ) + ( ( i + 1 )*sA2 ), A, sA1, sA2, oA + ( ( i + 1 )*( sA1 + sA2 ) ) ); // eslint-disable-line max-len


Don't be afraid to compute temporary variables here for your offset pointers.

kgryte · 2026-02-03T17:55:32Z

lib/node_modules/@stdlib/lapack/base/dgetc2/lib/base.js

+* @param {Int32Array} JPIV - vector of pivot indices for columns
+* @param {integer} strideJPIV - stride length for `JPIV`
+* @param {NonNegativeInteger} offsetJPIV - index offset for `JPIV`
+* @returns {integer} - status code


Suggested change

* @returns {integer} - status code

* @returns {integer} status code

kgryte · 2026-02-03T17:55:59Z

lib/node_modules/@stdlib/lapack/base/dgetc2/lib/base.js

+		// Find max element in matrix A
+		xmax = 0.0;
+		if ( isRowMajor( [ sA1, sA2 ] ) ) {
+			for ( ip = i; ip < N; ip++ ) {


See https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/ndarray/base/unary/lib/2d.js for how we typically do loop interchange.

kgryte · 2026-02-03T17:59:11Z

lib/node_modules/@stdlib/lapack/base/dgetc2/test/test.dgetc2.js

+}
+
+
+// FIXTURES //


Move above the "functions" section.

kgryte · 2026-02-03T17:59:29Z

lib/node_modules/@stdlib/lapack/base/dgetc2/test/test.dgetc2.js

+
+// Note: the outputs are tested against the outputs of the Fortran implementation.
+
+/* eslint-disable vars-on-top */


You should be able to remove this and re-enable lint rules.

stdlib-bot added LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Review A pull request which needs code review. labels Feb 3, 2026

prajjwalbajpai added 2 commits February 3, 2026 22:38

prajjwalbajpai mentioned this pull request Feb 3, 2026

Office Hours (2026-02-03) stdlib-js/meetings#78

Closed

kgryte reviewed Feb 3, 2026

View reviewed changes

lib/node_modules/@stdlib/lapack/base/dgetc2/test/test.dgetc2.js

}

// FIXTURES //

Copy link

Member

kgryte Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move above the "functions" section.

kgryte reviewed Feb 3, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add `lapack/base/dgetc2` #10071

feat: add `lapack/base/dgetc2` #10071

prajjwalbajpai commented Feb 3, 2026

Uh oh!

stdlib-bot commented Feb 3, 2026 •

edited

Loading

Uh oh!

kgryte Feb 3, 2026

Uh oh!

kgryte Feb 3, 2026

Uh oh!

kgryte Feb 3, 2026

Uh oh!

kgryte Feb 3, 2026

Uh oh!

kgryte Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	* @returns {integer} - status code
	* @returns {integer} status code


		// Note: the outputs are tested against the outputs of the Fortran implementation.

		/* eslint-disable vars-on-top */

Uh oh!

feat: add lapack/base/dgetc2 #10071

Are you sure you want to change the base?

feat: add lapack/base/dgetc2 #10071

Conversation

prajjwalbajpai commented Feb 3, 2026

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

kgryte Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

kgryte Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

kgryte Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

kgryte Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

kgryte Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add `lapack/base/dgetc2` #10071

feat: add `lapack/base/dgetc2` #10071

stdlib-bot commented Feb 3, 2026 •

edited

Loading