Skip to content

Fallback to auth token if a reranking key is not provided#2381

Merged
Hazel-Datastax merged 1 commit intomainfrom
hazel/fix-reranking-cred
Feb 9, 2026
Merged

Fallback to auth token if a reranking key is not provided#2381
Hazel-Datastax merged 1 commit intomainfrom
hazel/fix-reranking-cred

Conversation

@Hazel-Datastax
Copy link
Contributor

@Hazel-Datastax Hazel-Datastax commented Feb 9, 2026

What this PR does:

Which issue(s) this PR fixes:
Fixes #2383

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@Hazel-Datastax Hazel-Datastax requested a review from a team as a code owner February 9, 2026 22:03
Copy link
Contributor

@tatu-at-datastax tatu-at-datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

📉 Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 50.27%
This PR 50.27%
Delta 🔴 -0.00%
⚠️ Coverage decreased

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

Unit Test Coverage Report

Overall Project 50.27% -0.01% 🍏
Files changed 0%

File Coverage
RequestContext.java 23.26% -6.4%

@Hazel-Datastax Hazel-Datastax changed the title fallback to cassandra token if a reranking key is not provided Fallback to auth token if a reranking key is not provided Feb 9, 2026
Copy link
Contributor

@amorton amorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - that is actually a bug if we read what code comments says :)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

📈 Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 70.73%
This PR 70.73%
Delta 🟢 +0.00%
✅ Coverage improved!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

Integration Test Coverage Report (dse69-it)

Overall Project 70.73% 🍏
Files changed 100% 🍏

File Coverage
RequestContext.java 69.14% 🍏

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

📈 Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 72.48%
This PR 72.48%
Delta 🟢 +0.00%
✅ Coverage improved!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

Integration Test Coverage Report (hcd-it)

Overall Project 72.48% 🍏
Files changed 100% 🍏

File Coverage
RequestContext.java 69.14% 🍏

@Hazel-Datastax Hazel-Datastax merged commit 2d4154e into main Feb 9, 2026
3 checks passed
@Hazel-Datastax Hazel-Datastax deleted the hazel/fix-reranking-cred branch February 9, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: Reranking credentials missing fallback to authToken

3 participants