Add a failling test for node paths with parens#61
Draft
mattwynne wants to merge 1 commit intostacktracejs:masterfrom
Draft
Add a failling test for node paths with parens#61mattwynne wants to merge 1 commit intostacktracejs:masterfrom
mattwynne wants to merge 1 commit intostacktracejs:masterfrom
Conversation
mattwynne
force-pushed
the
allow-parens-in-node-filename
branch
from
3bbcef2 to
8f96eab
Compare
Contributor
Author
|
I don't know who needs to hear this but I have no |
Contributor
|
If this is still an issue, can you resolve the conflict and ping me back once done? |
Contributor
Author
|
We ended up solving the problem by switching to stackchain so I've lost personal interest in this I'm afraid. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #62
This PR is just a failing test to reproduce the problem. I'm hoping it should help someone who's a newcomer to open source and wants to contribute a fix.
I expect we can close this PR without merging it when someone submits a better PR that includes a fix 😄
Motivation and Context
Failing test to reproduce #62
How Has This Been Tested?
Added a new test case in spec/error-stack-parser-spec.js for this scenario.
Types of changes
Checklist:
node_modules/.bin/jscs -c .jscsrc error-stack-parser.jspasses without errorsnpm testpasses without errors