Update echo commands to use -e for escape sequences #2145
Merged
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix colored output on errors. It is quite easy to miss the failures otherwise. Co-authored-by: pescobar.it@gmail.com
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly identifies that echo requires the -e flag to interpret escape sequences for colored output. The changes add this flag to several echo commands in tools/rabbitmq-queue-migration.sh. My review suggests a further improvement: replacing echo -e with printf. While echo -e works in bash, printf is more portable and robust for handling escape sequences, which is a shell scripting best practice.
Alex-Welsh
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix colored output on errors. It is quite easy to miss the failures otherwise.
Co-authored-by: pescobar.it@gmail.com