Ubuntu Upgrade Script tweaks #2141
Conversation
jovial
commented
Feb 6, 2026
jovial
commented
- Tweaked ordering to fix various issues
- Added additional tags so that you can resume if something goes wrong
- Tweaked ordering to fix various issues - Added additional tags so that you can resume if something goes wrong
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Ubuntu upgrade playbook by reordering tasks and adding tags, which should make the process more robust and easier to resume on failure. The changes are logical, grouping repository cleanup tasks together. I've added a few suggestions to remove some minor redundancies introduced in the new code, such as an unnecessary loop and duplicate tags.
| ansible.builtin.blockinfile: | ||
| path: "{{ item }}" | ||
| state: absent | ||
| become: true | ||
| loop: | ||
| - /etc/apt/sources.list |
There was a problem hiding this comment.
This task uses a loop with a single item, which is redundant. The task can be simplified by removing the loop and setting the path directly.
ansible.builtin.blockinfile:
path: /etc/apt/sources.list
state: absent
become: true| remote_src: true | ||
| become: true | ||
| when: hostvars[inventory_hostname].stackhpc_repos_enabled | ||
| tags: post |
There was a problem hiding this comment.
The post tag is already applied to the entire play, so this tags definition is redundant and can be removed.
| - sources.list.d/ubuntu.sources | ||
| become: true | ||
| when: hostvars[inventory_hostname].stackhpc_repos_enabled | ||
| tags: post |
There was a problem hiding this comment.
The post tag is already applied to the entire play, so this tags definition is redundant and can be removed.
1 participant
