This repository was archived by the owner on Sep 8, 2021. It is now read-only.
Allow binary content to be returned from PHP#34
Open
joelbarnard wants to merge 1 commit intostackery:developmentfrom
Open
Allow binary content to be returned from PHP#34joelbarnard wants to merge 1 commit intostackery:developmentfrom
joelbarnard wants to merge 1 commit intostackery:developmentfrom
Conversation
To return Binary content through the ALB, it needs to be Base64 Encoded and the isBase64Encoded flag needs to be set to true.
txase
reviewed
May 8, 2019
Member
txase
left a comment
txase
left a comment
There was a problem hiding this comment.
This is helpful, though it has an issue in that it will base64 encode a lot of things that don't need it. Can we validate whether the body is invalid utf-8 first, and only then encode it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To return Binary content through the ALB, it needs to be Base64 Encoded and the isBase64Encoded flag needs to be set to true.
This change Base64 encodes all responses, and sets the isBase64Encoded flag to true, so that both plaintext and binary responses work.