Bugfix: issue #615, add Copied variant to Status enum and move panic to a copied status, add integration test #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 5, 2026 23:16
…move panic to a copied status, add integration test - The C status only appears in porcelain v2 when status.renames=copies is configured - --force skips the determine_refresh_paths dirty check loop, which is the only code path that calls Status::from_char. Thus, the panic only occurs without --force - The StatusEntryKind parsing already handles copies correctly (entry kind 2, same as renames)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #615
The crash only occurs in a specific code path.
Status::from_char()is called lazily.This happens only when
entry.index_status()orentry.worktree_status()is accessed indetermine_refresh_paths()inside theif !forceguard that checks whether the index and worktree are independently clean.Using
stg refresh --forceskips this check entirely, hiding the bug.I also added tests.
Notes:
status.renames=copiesis configured--forceskips thedetermine_refresh_pathsdirty check loop, which is the only code path that callsStatus::from_char. Thus, the panic only occurs without --forceStatusEntryKindparsing already handles copies correctly (entry kind 2, same as renames)This is a bit of a drive-by, I might be missing something but I think this is correct? Let me know if its just off or I am missing anything and can do further work