feat(terminal): restrict default allowed commands to 'ls' and 'echo'#372
Open
RonithManikonda wants to merge 8 commits intomainfrom
Open
feat(terminal): restrict default allowed commands to 'ls' and 'echo'#372RonithManikonda wants to merge 8 commits intomainfrom
RonithManikonda wants to merge 8 commits intomainfrom
Conversation
Change the default value of `terminal.allowCommands` from an empty array to `['ls', 'echo']`. This change prevents users from running all available commands by default in tutorials, enhancing security and focus. Lesson authors can still allow all commands by specifying `terminal.allowCommands: []` in the metadata. BREAKING CHANGE: The default value of `terminal.allowCommands` is now restricted to `['ls', 'echo']`. To allow all commands, explicitly set `terminal.allowCommands: []` in the metadata. Closes #302
|
|
AriPerkkio
suggested changes
Oct 14, 2024
docs/tutorialkit.dev/src/content/docs/reference/configuration.mdx
Outdated
Show resolved
Hide resolved
adjust tests to expect ['ls', 'echo'] as default allowCommands when undefined, aligning tests with updated functionality closes #302
Deploying tutorialkit-demo-page with
|
| Latest commit: |
43c24c4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cdcd4fde.tutorialkit-demo-page.pages.dev |
| Branch Preview URL: | https://ronith-hide-toggle-terminal.tutorialkit-demo-page.pages.dev |
AriPerkkio
suggested changes
Nov 1, 2024
Co-authored-by: Ari Perkkiö <ari.perkkio@gmail.com>
Co-authored-by: Ari Perkkiö <ari.perkkio@gmail.com>
AriPerkkio
suggested changes
Nov 8, 2024
Contributor
AriPerkkio
left a comment
AriPerkkio
left a comment
There was a problem hiding this comment.
Some of the tests are still failing, could you take a look at those? 👀
Change the default value of `terminal.allowCommands` from an empty array to `['ls', 'echo']`. This update enhances security and focus by limiting the commands available in tutorials by default. Lesson authors can still enable all commands by setting `terminal.allowCommands: []` explicitly in the metadata. BREAKING CHANGE: The default value of `terminal.allowCommands` is now restricted to `['ls', 'echo']`. To allow all commands, explicitly set `terminal.allowCommands: []` in the metadata. Closes #372
AriPerkkio
approved these changes
Jan 16, 2025
Contributor
AriPerkkio
left a comment
AriPerkkio
left a comment
There was a problem hiding this comment.
Looks good, great work @RonithManikonda! 💯
As this change is a breaking change, we'll merge this into main before releasing version 2.0.0 of TutorialKit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the default value of
terminal.allowCommandsfrom an empty array to['ls', 'echo']. This change prevents users from running all available commands by default in tutorials, enhancing security and focus. Lesson authors can still allow all commands by specifyingterminal.allowCommands: []in the metadata.BREAKING CHANGE: The default value of
terminal.allowCommandsis now restricted to['ls', 'echo']. To allow all commands, explicitly setterminal.allowCommands: []in the metadata.Closes #302