Open
Conversation
Member
|
This would be a good thing in theory, but it would require a major version bump. Maybe we can include that when we need to break backwards compatibility anyway |
Author
|
Makes sense. Would it be possible to make a prerelease of some sort which includes this? Or is it too far in time? |
Author
|
Another suggestion: Something like const initSqlJs = require('sql.js');
initSqlJs.throwAsErrors = true; |
|
Definitely a good way to incorporate the behaviour keeping it optional and eventually making it the default whenever a major bump is planned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwing strings makes it difficult to debug for specific issues when working on projects that use sql.js.
Replaced string with Errors when being thrown. (Really just using a constructor around the string).