functions TypeRegistry.shutdownFileSystemWatcherThread and FileSystemWatcher.shutdownAndWait#72
Open
akhikhl wants to merge 1 commit intospring-projects:masterfrom
Open
functions TypeRegistry.shutdownFileSystemWatcherThread and FileSystemWatcher.shutdownAndWait#72akhikhl wants to merge 1 commit intospring-projects:masterfrom
akhikhl wants to merge 1 commit intospring-projects:masterfrom
Conversation
… FileSystemWatcher.shutdownAndWait
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
I integrate springloaded and embedded tomcat in gretty gradle plugin.
Problem
When stopping/restarting webapp under embedded tomcat with springloaded agent, tomcat issues warning:
The warning is apparently related to the fact that FileSystemWatcher thread is still running, even when related classloader goes out of scope (as by webapp stop/restart),
Solution
I need the new function
TypeRegistry.shutdownFileSystemWatcherThreadin order to deterministically shut down springloaded threads before webapp is stopped.