feat(oauth): Add refresh to oauthdevice.Client#1227
feat(oauth): Add refresh to oauthdevice.Client#1227burmudar wants to merge 2 commits intowb/add-oauth-device-flowfrom
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
keegancsmith
left a comment
keegancsmith
left a comment
There was a problem hiding this comment.
did you test what happens if someone revokes src-cli and then you try refresh a token / use an old token? I'm interested to know if the error message you show users is possible to debug as that being the issue.
| } | ||
|
|
||
| // Refresh exchanges a refresh token for a new access token. | ||
| func (c *httpClient) Refresh(ctx context.Context, endpoint, refreshToken string) (*TokenResponse, error) { |
There was a problem hiding this comment.
does this just magically get used to refresh in our client?
There was a problem hiding this comment.
Not yet! There is some code I still need to land which adds a transport which will do automatic refresh if you use api.Client
Noopee! Def a good call out - I'll make sure to test it |
burmudar
force-pushed
the
wb/add-oauth-device-flow
branch
from
fd1668e to
1565618
Compare
burmudar
force-pushed
the
wb/add-oauth-refresh-token
branch
from
2f24f44 to
7f2c665
Compare
burmudar
force-pushed
the
wb/add-oauth-device-flow
branch
from
1565618 to
9a04958
Compare
burmudar
force-pushed
the
wb/add-oauth-refresh-token
branch
from
7f2c665 to
87b5732
Compare
2 participants
add refresh to oauthdevice.Client
oauthdevice: add RefreshToken field and Refresh method
Test plan