improvement(action-bar): run button label and hover#3128
Open
emir-karabeg wants to merge 3 commits intostagingfrom
Open
improvement(action-bar): run button label and hover#3128emir-karabeg wants to merge 3 commits intostagingfrom
emir-karabeg wants to merge 3 commits intostagingfrom
Conversation
- Changed 'Run from block' to 'Run' in tooltip - Updated disabled state hover to show 'Disabled: Run Blocks Before' Co-authored-by: Emir Karabeg <emir-karabeg@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryUpdated the "Run from block" button label in the action bar to simply "Run" and improved the disabled state tooltip to "Disabled: Run Blocks Before" for better clarity. The changes maintain consistent messaging between the action bar and context menu logic. Issue Found:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant ActionBar
participant Tooltip
participant WorkflowStore
participant ExecutionStore
User->>ActionBar: Hover over Run button
ActionBar->>WorkflowStore: Check block state (isEnabled, locked, etc)
ActionBar->>ExecutionStore: Check execution state (isExecuting)
ActionBar->>ActionBar: Calculate dependenciesSatisfied
alt Button disabled (permissions)
ActionBar->>Tooltip: Show "Run" with getTooltipMessage()
Tooltip-->>User: Display "Read-only mode" or "Connection lost"
else Execution in progress
ActionBar->>Tooltip: Show "Execution in progress"
Tooltip-->>User: Display message
else Dependencies not satisfied
ActionBar->>Tooltip: Show "Disabled: Run Blocks Before"
Tooltip-->>User: Display message
else Can run
ActionBar->>Tooltip: Show "Run"
Tooltip-->>User: Display message
end
User->>ActionBar: Click Run button (if enabled)
ActionBar->>WorkflowStore: handleRunFromBlock(blockId)
WorkflowStore->>ExecutionStore: Execute workflow from block
|
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/action-bar/action-bar.tsx
Show resolved
Hide resolved
Collaborator
|
@cursor review |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the "Run from block" button in the action bar to simply "Run". When the button is disabled due to unsatisfied dependencies, the hover tooltip now displays "Disabled: Run Blocks Before" for improved clarity.
Type of Change
Testing
The changes were verified by running lint and type checks. Visual inspection of the action bar button and its hover states (enabled and disabled) is recommended.
Checklist
Screenshots/Videos