DOC Update X-Forwarded-Proto header documentation#889
Draft
emteknetnz wants to merge 1 commit intosilverstripe:5.4from
Draft
DOC Update X-Forwarded-Proto header documentation#889emteknetnz wants to merge 1 commit intosilverstripe:5.4from
emteknetnz wants to merge 1 commit intosilverstripe:5.4from
Conversation
4 tasks
emteknetnz
force-pushed
the
pulls/5.4/update-proxy-header
branch
2 times, most recently
from
7446da7 to
f72e707
Compare
emteknetnz
commented
Mar 2, 2026
|
|
||
| ```yml | ||
| SilverStripe\Control\HTTP: | ||
| vary: "" |
Member
Author
There was a problem hiding this comment.
Docs are wrong - this config was removed in CMS 5 - https://github.com/silverstripe/silverstripe-framework/compare/4.13.0..5.0#diff-81fbdb33fe3af70ba0afb63aee887de629bb89bf0a0c822eb9c73516af47cbffL88
emteknetnz
commented
Mar 2, 2026
| Vary: X-Forwarded-Protocol | ||
| ``` | ||
| > [!NOTE] | ||
| > Prior to Silverstripe CMS 5.4, the default `Vary` header was set to the non-standard |
Member
Author
There was a problem hiding this comment.
If we continue to target CMS 5.4, we'd need to put in the exact patch version this changes
emteknetnz
commented
Mar 2, 2026
| sets the `X-Forwarded-Proto` header and the application is configured to trust it via | ||
| [`TrustedProxyMiddleware`](api:SilverStripe\Control\Middleware\TrustedProxyMiddleware). | ||
|
|
||
| You can also add additional headers to vary on. For example, if you use `Director::is_ajax()` on |
Member
Author
There was a problem hiding this comment.
Slightly unrelated docs improvement
emteknetnz
force-pushed
the
pulls/5.4/update-proxy-header
branch
from
f72e707 to
8d655d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#11973