Conversation
No change to logic. This fixes some lint errors. This is technically a breaking change because we're dropping official support for node v4 (although the real breaking change will come after this when I update shelljs). For some reason the old eslint-wrapper wasn't actually reporting lint errors (there were several on the main branch). I'm not going to debug this since we can just delete the wrapper entirely.
Member
Author
|
The failures on macOS are just because GitHub dropped support for running old node versions on Mac. I'm going to ignore those errors and merge this anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No change to logic. This fixes some lint errors. This is technically a breaking change because we're dropping official support for node v4 (although the real breaking change will come after this when I update shelljs).
For some reason the old eslint-wrapper wasn't actually reporting lint errors (there were several on the main branch). I'm not going to debug this since we can just delete the wrapper entirely.