This repository was archived by the owner on Oct 24, 2025. It is now read-only.
feat: Support pipenv users whose Pipfile is not in servicePath (serverless.yml location)#858
Open
alanmun wants to merge 1 commit intoserverless:masterfrom
Open
feat: Support pipenv users whose Pipfile is not in servicePath (serverless.yml location)#858alanmun wants to merge 1 commit intoserverless:masterfrom
alanmun wants to merge 1 commit intoserverless:masterfrom
Conversation
3 tasks
Author
|
@Mmarzex Hi sorry to be a bother but any chance this could get looked at? My company would appreciate the functionality :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if you have a project hierarchy like:
And run sls deploy in the same dir as the serverless.yml like:
~/MyCode/root/src$ pipenv run sls deployCurrently this plugin silently fails to detect your Pipfile. This PR adds code to bubble up until either your operating system's root dir is reached or Pipfile is found. This matches with pipenv's behavior, which is to support executing pipenv commands such as
pipenv run,pipenv shell, andpipenv requirementsin any subdirectory of a directory containing your Pipfile/the directory where you created your virtualenv.With this code change, my project hierarchy which looks like the above now successfully packages my serverless project with all of the pipenv generated requirements.
Resolves #857