Support noDeploy option when use layers#759
Support noDeploy option when use layers#759naoyasugita wants to merge 7 commits intoserverless:masterfrom
Conversation
|
Thank you @naoyasugita! I need this as well, looking forward to it being merged. |
|
Hi @pgrzesik - I'd be happy to check in with you when you're ready. |
|
I hope this gets merged soon! |
pgrzesik
left a comment
pgrzesik
left a comment
There was a problem hiding this comment.
Thanks for proposing the fix and sorry for not responding sooner. Please see my comment and let me know what do you think. Also, would be good if we could have a test case covering this.
lib/zipTree.js
Outdated
| * @param {Object} noDeploy | ||
| * @return {Promise} a promise offering the original JSZip object. | ||
| */ | ||
| function addTreeNoDeploy(zip, src, noDeploy) { |
There was a problem hiding this comment.
I think we don't need a new function just for that as most of the logic is copied over from the original addTree. I think it would be better to just have the optional argument of noDeploy to the original function. What do you think?
There was a problem hiding this comment.
Thanks for the review :)
You are right. I'll fix it along with the test.
There was a problem hiding this comment.
@pgrzesik I'm done adding test and fixing the code. Please check it out.
|
Hey @naoyasugita - it looks like the tests are currently failing. Could you please look into that whenever you have a chance? 🙇 |
4 participants
This change allows use of noDeploy option with the layers.
Should resolve:
#577