This repository was archived by the owner on Jan 20, 2026. It is now read-only.
Conversation
Kbhat1
approved these changes
Oct 8, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (40.06%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 40.00% 40.06% +0.06%
==========================================
Files 59 59
Lines 7510 7533 +23
==========================================
+ Hits 3004 3018 +14
- Misses 4161 4168 +7
- Partials 345 347 +2
🚀 New features to boost your workflow:
|
masih
reviewed
Oct 9, 2025
Collaborator
masih
left a comment
There was a problem hiding this comment.
Late to the party but this LGTM, thank you for actioning this so quickly @yzang2019 🍻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Remove SQLITE backend from ss store since we do not plan to support it and we have never used that before.
Testing performed to validate your change