fix: respect existing genesis file #2868
Merged
+196
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2868 +/- ##
=======================================
Coverage 48.31% 48.31%
=======================================
Files 671 671
Lines 50580 50580
=======================================
+ Hits 24438 24440 +2
+ Misses 24001 24000 -1
+ Partials 2141 2140 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
masih
approved these changes
Feb 12, 2026
Collaborator
masih
left a comment
masih
left a comment
There was a problem hiding this comment.
Nice thank you for getting this sorted so quickly 🚀
No blockers; just minor comments.
cmd/seid/cmd/init.go
Outdated
| return nil, errors.Wrap(err, "Failed to marshall default genesis state") | ||
| } | ||
| genDoc := &types.GenesisDoc{ChainID: chainID, AppState: appState} | ||
| if fi, err := os.Stat(genFile); err == nil { |
Collaborator
There was a problem hiding this comment.
Ditto re DIR check. We probably can refactor the existing file checking to use here as well as above.
cmd/seid/cmd/init_test.go
Outdated
| func TestLoadOrWriteGenesis_ExplicitConfigWins(t *testing.T) { | ||
| dir := t.TempDir() | ||
| genFile := filepath.Join(dir, "genesis.json") | ||
| chainID := "atlantic-2" |
Collaborator
There was a problem hiding this comment.
I would define this as const instead of var? Ditto for other such names constant in this file.
sei-will
approved these changes
Feb 12, 2026
yzang2019
added a commit
that referenced
this pull request
Feb 12, 2026
* main: chore: remove wasm dir on unsafe-reset (#2875) fix: respect existing genesis file (#2868) fix to halt due to reconstructing block from bad proposal (backported #2823) (#2873) chore(refactor): drop unused code (#2811) made the peer dialing less aggressive (backported #2799) (#2872) perf(store): lazy-init `sortedCache` in `cachekv.Store` (#2804) feat: embed genesis for well-known chains (#2835) fix: use MADV_RANDOM during loadtree (#2857)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This PR is a followup for #2835 to handle a case where the user already has their own genesis file and does not want to remove them or overwrite them. Here is the slack comment by @masih that suggested this fix: https://sei-network-io.slack.com/archives/C06A3D4FWE5/p1770833867974669?thread_ts=1770803742.497719&cid=C06A3D4FWE5
Testing performed to validate your change