Skip to content

Conversation

@codchen
Copy link
Collaborator

@codchen codchen commented Feb 12, 2026

Describe your changes and provide context

Giga executors may yield different gas usage than v2 executors due to:

  • more parity with Ethereum
  • optimized state access pattern
    Since we only care about state consistency, which is covered by AppHash, we don't need to require lastResultsHash on nodes that enabled giga.

Testing performed to validate your change

patch on giga-enabled RPC nodes

@github-actions
Copy link

github-actions bot commented Feb 12, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 12, 2026, 4:35 AM

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.07%. Comparing base (7db2f0a) to head (cffaeaa).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/test_helpers.go 0.00% 1 Missing ⚠️
sei-tendermint/light/rpc/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2866       +/-   ##
===========================================
+ Coverage   48.32%   57.07%    +8.75%     
===========================================
  Files         671     2090     +1419     
  Lines       50576   171162   +120586     
===========================================
+ Hits        24439    97696    +73257     
- Misses      23998    64775    +40777     
- Partials     2139     8691     +6552     
Flag Coverage Δ
sei-chain 52.53% <66.66%> (?)
sei-cosmos 48.13% <ø> (-0.01%) ⬇️
sei-db 68.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/app.go 65.90% <100.00%> (ø)
sei-tendermint/internal/state/execution.go 80.42% <100.00%> (ø)
sei-tendermint/internal/state/validation.go 100.00% <100.00%> (ø)
sei-tendermint/types/block.go 87.88% <ø> (ø)
sei-tendermint/types/evidence.go 77.65% <100.00%> (ø)
app/test_helpers.go 40.13% <0.00%> (ø)
sei-tendermint/light/rpc/client.go 0.00% <0.00%> (ø)

... and 1535 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

if err != nil {
// Check if this is a LastResultsHash mismatch and log detailed info
if !bytes.Equal(block.LastResultsHash, state.LastResultsHash) {
if !types.SkipLastResultsHashValidation.Load() && !bytes.Equal(block.LastResultsHash, state.LastResultsHash) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually work? I think you're just skipping the log, but still returning the error here, so I don't think SkipLastResultsHashValidation actually does anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants