Skip to content

Conversation

@stevenlanders
Copy link
Contributor

Describe your changes and provide context

This PR introduces three critical fixes to align the Giga executor with V2 behavior and resolve apphash mismatches:

  1. Initial Fee Validation: Implements upfront fee validation (fee cap, tip cap, overflow, gas limit) before EVM execution, mirroring V2's ante handler. This fix ensures the nonce is correctly incremented even when validation fails.
  2. Return All Balances: Updates the bank keeper's SpendableCoins() to return all token balances, not just usei, addressing an apphash mismatch and enabling multi-token support.
  3. Nonce Increment on Early Exit: Ensures the transaction nonce is incremented even when transactions fail validation early, preventing nonce desynchronization and further apphash mismatches.

These changes are crucial for maintaining consensus and state parity between Giga and V2 execution paths.

Testing performed to validate your change

This PR is intended to be merged into staging-feb13/giga-6.3.0 for comprehensive testing. Further unit, integration, and regression tests are recommended, especially for validation failure paths and the specific transactions that triggered the apphash mismatches.


Slack Thread

Open in Cursor Open in Web

Co-authored-by: Steven Landers <steven.landers@gmail.com>
@cursor
Copy link

cursor bot commented Feb 11, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@github-actions
Copy link

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 11, 2026, 9:43 PM

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.11%. Comparing base (7db2f0a) to head (89344e9).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2863       +/-   ##
===========================================
+ Coverage   48.32%   57.11%    +8.78%     
===========================================
  Files         671     2090     +1419     
  Lines       50576   171169   +120593     
===========================================
+ Hits        24439    97755    +73316     
- Misses      23998    64720    +40722     
- Partials     2139     8694     +6555     
Flag Coverage Δ
sei-chain 52.56% <ø> (?)
sei-cosmos 48.13% <ø> (-0.01%) ⬇️
sei-db 68.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1542 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants