perf(store): replace sync.Map with plain map in cachekv stores #2855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Within OCC, each worker gets its own CacheMultiStore chain with
dedicated cachekv.Store instances — zero concurrent access. The
sync.Map thread-safety overhead (CAS, internal node allocs) is
pure waste in this single-goroutine context.
Replace *sync.Map with typed Go maps in both sei-cosmos and giga
cachekv implementations:
- cache: map[string]*types.CValue
- deleted: map[string]struct{}
- unsortedCache: map[string]struct{}
Keep sync.RWMutex for defense-in-depth (uncontested, <20ns).
Micro-benchmarks: 32-56% faster across all cachekv operations,
4 allocs/op eliminated from Set paths.
TPS benchmark: ~8,936 avg (+14.6% cumulative over origin/main).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pdrobnjak
force-pushed
the
perf/replace-syncmap-cachekv
branch
from
bb5063e to
bbff2d7
Compare
pdrobnjak
force-pushed
the
perf/skip-redundant-snapshot
branch
from
08c4efe to
8d2dc33
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2855 +/- ##
==========================================
- Coverage 46.28% 46.23% -0.05%
==========================================
Files 2005 2005
Lines 163018 163027 +9
==========================================
- Hits 75449 75374 -75
- Misses 81047 81131 +84
Partials 6522 6522
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+117
to
+120
| for key, cv := range store.cache { | ||
| // Replace with a clean (non-dirty) version of the same value | ||
| store.cache.Store(key, types.NewCValue(cv.Value(), false)) | ||
| return true | ||
| }) | ||
| store.cache[key] = types.NewCValue(cv.Value(), false) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+173
to
+184
| for key, cv := range store.cache { | ||
| kbz := []byte(key) | ||
| if bytes.Compare(kbz, start) < 0 || bytes.Compare(kbz, end) >= 0 { | ||
| // we don't want to break out of the iteration since cache isn't sorted | ||
| return true | ||
| continue | ||
| } | ||
| cv := value.(*types.CValue) | ||
| if cv.Value() == nil { | ||
| delete(keyStrs, key.(string)) | ||
| delete(keyStrs, key) | ||
| } else { | ||
| keyStrs[key.(string)] = struct{}{} | ||
| keyStrs[key] = struct{}{} | ||
| } | ||
| return true | ||
| }) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+276
to
+282
| for cKey := range store.unsortedCache { | ||
| if dbm.IsKeyInDomain(conv.UnsafeStrToBytes(cKey), start, end) { | ||
| cacheValue, ok := store.cache.Load(key) | ||
| if ok { | ||
| unsorted = append(unsorted, &kv.Pair{Key: []byte(cKey), Value: cacheValue.(*types.CValue).Value()}) | ||
| if cacheValue, ok := store.cache[cKey]; ok { | ||
| unsorted = append(unsorted, &kv.Pair{Key: []byte(cKey), Value: cacheValue.Value()}) | ||
| } | ||
| } | ||
| return true | ||
| }) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+359
to
+370
| for key, cv := range store.cache { | ||
| kbz := []byte(key) | ||
| if bytes.Compare(kbz, start) < 0 || bytes.Compare(kbz, end) >= 0 { | ||
| // we don't want to break out of the iteration since cache isn't sorted | ||
| return true | ||
| continue | ||
| } | ||
| cv := value.(*types.CValue) | ||
| if cv.Value() == nil { | ||
| delete(keyStrs, key.(string)) | ||
| delete(keyStrs, key) | ||
| } else { | ||
| keyStrs[key.(string)] = struct{}{} | ||
| keyStrs[key] = struct{}{} | ||
| } | ||
| return true | ||
| }) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sync.Mapwith plainmapin cachekv stores for better performanceStack
8/19 — depends on perf/skip-redundant-snapshot (replaces auto-closed #2822)
🤖 Generated with Claude Code